fix(storage): Handle request transformation after gRPC BidiWriteObject redirects#16073
fix(storage): Handle request transformation after gRPC BidiWriteObject redirects#16073kalragauri wants to merge 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the propagation of routing tokens across retries for asynchronous appendable uploads. It introduces a RoutingHeaderOptions structure to manage tokens in gRPC metadata and adds the HandleBidiWriteRedirect utility to centralize redirect handling and request specification updates. Feedback identifies that the call to HandleBidiWriteRedirect within AsyncWriterConnectionImpl::OnQuery is ineffective, as the modified request state is not preserved or propagated back to the higher-level retry loop in AsyncConnectionImpl.
kalragauri
force-pushed
the
feature/append-object
branch
from
18a62db to
30b6578
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16073 +/- ##
==========================================
+ Coverage 92.67% 92.68% +0.01%
==========================================
Files 2343 2343
Lines 217117 217433 +316
==========================================
+ Hits 201221 201537 +316
Misses 15896 15896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalragauri
force-pushed
the
feature/append-object
branch
from
30b6578 to
56269bc
Compare
…Object redirects This commit addresses an issue where BidiWriteObject operations, particularly in cross-region redirect scenarios, would fail with a NOT_FOUND error. The root cause was that bucket information was not propagated in the request headers after the client received a redirect error from the service.
kalragauri
force-pushed
the
feature/append-object
branch
from
388518a to
0d5a3d0
Compare
3 participants
This commit addresses an issue where gRPC BidiWriteObject operations, particularly in cross-region redirect scenarios, would fail with a NOT_FOUND error. The root cause was that bucket information was not propagated in the request headers after the client received a redirect error from the service.